Skip to content

[SYCL][COMPAT] Ensure launched kernels are fully inlined #15941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Nov 6, 2024
Merged

[SYCL][COMPAT] Ensure launched kernels are fully inlined #15941

merged 10 commits into from
Nov 6, 2024

Conversation

@joeatodd
Copy link
Contributor

@joeatodd joeatodd commented Oct 31, 2024

This PR defines & uses a custom syclcompat::detail::apply_helper with [[clang::always_inline]] to ensure kernels are inlined.

@joeatodd joeatodd requested a review from a team as a code owner October 31, 2024 09:23
FMarno
FMarno reviewed Nov 1, 2024
View reviewed changes
@joeatodd
Remove dummy_fn
719ff74 
We are testing for kernel inlining, dummy_fn inlining is a separate
issue
@joeatodd
Formatting
3e43f4c
Alcpz
Alcpz approved these changes Nov 6, 2024
View reviewed changes
Copy link
Contributor

@Alcpz Alcpz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing this @joeatodd !

@joeatodd
Copy link
Contributor Author

joeatodd commented Nov 6, 2024

@intel/llvm-gatekeepers this is ready to merge 🙏

@martygrant martygrant merged commit dc181bb into intel:sycl Nov 6, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@FMarno FMarno FMarno left review comments

@aacostadiaz aacostadiaz aacostadiaz left review comments

@Alcpz Alcpz Alcpz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@joeatodd @Alcpz @FMarno @aacostadiaz @martygrant